Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Cleanup network AnyHttpUrlLegacy and HttpUrlLegacy #6767

Merged
merged 3 commits into from
Nov 20, 2024
Merged

♻️ Cleanup network AnyHttpUrlLegacy and HttpUrlLegacy #6767

merged 3 commits into from
Nov 20, 2024

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 19, 2024 •
edited
Loading

What do these changes do?

Clean up the AnyHttpUrlLegacy and HttpUrlLegacy to use the Pydantic v2 ones.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (0aea337) to head (3af1779).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files 
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6767      +/-   ##
===============================================================================
+ Coverage                                        83.84%   86.46%   +2.62%     
===============================================================================
  Files                                             1513     1236     -277     
  Lines                                            61011    52709    -8302     
  Branches                                          2010      917    -1093     
===============================================================================
- Hits                                             51153    45574    -5579     
+ Misses                                            9539     6988    -2551     
+ Partials                                           319      147     -172
Flag Coverage Δ
integrationtests 64.79% <ø> (+11.32%) ⬆️
unittests 84.00% <100.00%> (+0.31%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.24% <100.00%> (-0.01%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent ∅ <ø> (∅)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 75.99% <ø> (ø)
director_v2 91.03% <ø> (+14.50%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <100.00%> (-0.05%) ⬇️
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <100.00%> (-0.01%) ⬇️
resource_usage_tracker 90.79% <ø> (+0.14%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.49% <ø> (+1.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aea337...3af1779. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo marked this pull request as ready for review November 19, 2024 15:28
@giancarloromeo giancarloromeo changed the title ♻️ Cleanup network legacy ♻️ Cleanup network AnyHttpUrlLegacy and HttpUrlLegacy Nov 19, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 19, 2024
pcrespov
pcrespov approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

sanderegg
sanderegg approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@giancarloromeo giancarloromeo merged commit c49f421 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 20, 2024
2 checks passed
@giancarloromeo giancarloromeo deleted the is4481/cleanup-network-legacy branch November 20, 2024 07:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@giancarloromeo giancarloromeo

Labels
None yet
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
4 participants
@giancarloromeo @pcrespov @sanderegg @matusdrobuliak66